Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*): utilize custom indigo icons when indigo theme is used #14520

Merged
merged 21 commits into from
Sep 20, 2024

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Jul 15, 2024

Closes #14007

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff changed the title Simeonoff/indigo icons refactor(*): utilize custom indigo icons when indigo theme is used Jul 15, 2024
@andiesm813
Copy link

Hey, i'm not sure if you are done replacing the icons in all components.... here's some feedback of what i saw :)

TABS
The navigation icons are supposed to be smaller, like on Figma.

image

DROPDOWN BUTTON
The components that have dropdown button like Combo & Select should not have background on the dropdown button. Here's the comparison.

image

GRID FILTERING DIALOG

  1. Some of the icons are bigger than the other icons. This happens in all sizes. See the Figma image for reference.
  2. I'm not sure if this branch includes styling of the grid, because i guess that's why icons appear blue and not gray, like in the design.

image

PIVOTGRID
I suppose this component has not been fully styled as well. There is a problem with the chevrons sizing there as well in some places.

image

PAGINATOR
Since i didn't work on the paginator component styling, i failed to provide those 2 icons to be used in the paginator. I can add them to Figma in a new branch so you guys can update them too. Sounds good @simeonoff @sdimchevski ?

image

@desig9stein desig9stein added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 22, 2024
@simeonoff simeonoff removed the ✅ status: verified Applies to PRs that have passed manual verification label Aug 2, 2024
@simeonoff simeonoff changed the base branch from master to 18.1.x August 15, 2024 08:18
@simeonoff
Copy link
Collaborator Author

Hey, i'm not sure if you are done replacing the icons in all components.... here's some feedback of what i saw :)

TABS The navigation icons are supposed to be smaller, like on Figma.

image

This should be fixed.

DROPDOWN BUTTON The components that have dropdown button like Combo & Select should not have background on the dropdown button. Here's the comparison.

image

This is resolved in another PR

GRID FILTERING DIALOG

  1. Some of the icons are bigger than the other icons. This happens in all sizes. See the Figma image for reference.
  2. I'm not sure if this branch includes styling of the grid, because i guess that's why icons appear blue and not gray, like in the design.

image

  1. Some of the icons are bigger than the other icons. This happens in all sizes. See the Figma image for reference. - Should be fixed now.

  2. I'm not sure if this branch includes styling of the grid, because i guess that's why icons appear blue and not gray, like in the design. - Yes, this needs to be resolved in the theme update PR.

PIVOTGRID I suppose this component has not been fully styled as well. There is a problem with the chevrons sizing there as well in some places.

image

Yes, again, it should be styled in another PR.

PAGINATOR Since i didn't work on the paginator component styling, i failed to provide those 2 icons to be used in the paginator. I can add them to Figma in a new branch so you guys can update them too. Sounds good @simeonoff @sdimchevski ?

image

For now I haven't updated the icons in the paginator. If you feel like creating two more icons I can update them as well.

@simeonoff simeonoff marked this pull request as ready for review August 16, 2024 11:51
@simeonoff simeonoff changed the base branch from 18.1.x to master August 16, 2024 11:52
@yradoeva

This comment was marked as resolved.

@yradoeva

This comment was marked as resolved.

@yradoeva

This comment was marked as resolved.

@yradoeva

This comment was marked as resolved.

@simeonoff simeonoff merged commit 72a060f into master Sep 20, 2024
4 checks passed
@simeonoff simeonoff deleted the simeonoff/indigo-icons branch September 20, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indigo Theme: Register custom icons
8 participants